Comments on: Exploring Lucene’s Indexing Code: Part 1

By: Mark Miller

Mark Miller — Mon, 23 Mar 2009 10:24:41 +0000

The issue with the shared StringBuilder is that the indenting (which the StringBuilder is used for), won’t work correctly if the builder/buffer is shared across threads. That is why I didn’t just use a StringBuffer – I didn’t want to lull anyone into thinking the code was written to work with multiple threads – the indenting would have to be tracked per thread.

By: Lance Norskog

Lance Norskog — Mon, 23 Mar 2009 01:51:42 +0000

StringBuilder (as of Java 1.5) has replaced StringBuffer as the class used by the compiler to implement “string + string + string”. StringBuffer is thread-safe (and thus much much slower) and can be used in this example.

(StringBuffer is like Hashtable and Vector: thread-safe doodads from original Java because of course everyone will write multi-threaded code with this great new language that makes threaded code easy and fun.)

By: Lucid Imagination » Exploring Lucenes Indexing Code: Part 2

Lucid Imagination » Exploring Lucenes Indexing Code: Part 2 — Wed, 18 Mar 2009 21:37:45 +0000

[...] Previous: Exploring Lucenes Indexing Code: Part 1 [...]

By: Mark Miller

Mark Miller — Thu, 05 Mar 2009 23:18:15 +0000

No problem Mike – I’ve added a sample aspect to the post.

By: Mike Smith

Mike Smith — Thu, 05 Mar 2009 22:33:07 +0000

Can you can export that from Eclipse and share?

By: Mark Miller

Mark Miller — Thu, 05 Mar 2009 16:57:22 +0000

Hey Stephen,

I use AspectJ to get the traces. That allows me to very simply weave code into the Lucene code base. Its a very simple aspect that simply injects a trace before and after selected method calls. Every ‘before’ I increase the indent and every ‘after’ I decrease it. Fairly simple, but pretty effective. AspectJ has some command line tools, but I just used the Eclipse integration – only took about 5 minutes to setup – you simply drop the aspect file into the Lucene project and run it.

By: Stephen Green

Stephen Green — Thu, 05 Mar 2009 15:04:39 +0000

Interesting stuff, Mark.

How did you generate those traces? That would be a very handy tool to have around…